Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move to madmin-go package #765

Merged
merged 1 commit into from
Jun 1, 2021
Merged

move to madmin-go package #765

merged 1 commit into from
Jun 1, 2021

Conversation

harshavardhana
Copy link
Member

No description provided.

@dvaldivia dvaldivia requested review from bexsoft, dvaldivia, Alevsk and adfost and removed request for bexsoft and dvaldivia May 21, 2021 19:28
@harshavardhana harshavardhana force-pushed the fix-console branch 2 times, most recently from f333283 to 66654d0 Compare May 31, 2021 03:53
@harshavardhana harshavardhana marked this pull request as ready for review May 31, 2021 03:53
@harshavardhana harshavardhana added the needed High Priority label May 31, 2021
@harshavardhana harshavardhana force-pushed the fix-console branch 5 times, most recently from 7e865c1 to f44ae60 Compare May 31, 2021 04:10
dvaldivia
dvaldivia previously approved these changes May 31, 2021
View reviewed changes
bexsoft
bexsoft requested changes Jun 1, 2021
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting # github.com/minio/console/cmd/console /usr/local/Cellar/go/1.16/libexec/pkg/tool/darwin_amd64/link: running clang failed: exit status 1 duplicate symbol '_readdrivestat' in: /var/folders/fj/xhr255q51gg8cm67pz5kqz0m0000gn/T/go-link-576402205/000020.o /var/folders/fj/xhr255q51gg8cm67pz5kqz0m0000gn/T/go-link-576402205/000036.o duplicate symbol '_get_temperature' in: /var/folders/fj/xhr255q51gg8cm67pz5kqz0m0000gn/T/go-link-576402205/000023.o /var/folders/fj/xhr255q51gg8cm67pz5kqz0m0000gn/T/go-link-576402205/000039.o duplicate symbol '_open_smc' in: /var/folders/fj/xhr255q51gg8cm67pz5kqz0m0000gn/T/go-link-576402205/000023.o /var/folders/fj/xhr255q51gg8cm67pz5kqz0m0000gn/T/go-link-576402205/000039.o duplicate symbol '_close_smc' in: /var/folders/fj/xhr255q51gg8cm67pz5kqz0m0000gn/T/go-link-576402205/000023.o /var/folders/fj/xhr255q51gg8cm67pz5kqz0m0000gn/T/go-link-576402205/000039.o ld: 4 duplicate symbols for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) during build time, investigating further

bexsoft
bexsoft approved these changes Jun 1, 2021
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good by adding CGO_ENABLED=0 & --tags=kqueue flags to runtime in case of using MacOS.

@harshavardhana harshavardhana merged commit eff001b into minio:master Jun 1, 2021
@harshavardhana harshavardhana deleted the fix-console branch June 1, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alevsk Alevsk Alevsk approved these changes

@dvaldivia dvaldivia dvaldivia approved these changes

@bexsoft bexsoft bexsoft approved these changes

@adfost adfost Awaiting requested review from adfost

Assignees

@harshavardhana harshavardhana

Labels
needed High Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@harshavardhana @Alevsk @dvaldivia @bexsoft