Add Filtering to Users on Policy Details #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
requested changes
Jun 23, 2021
| api | ||
| .invoke("GET", `/api/v1/policies/${policyName}/users`) | ||
| .then((result: any) => { | ||
| var resultUserArray = result.map((x: string) => { |
There was a problem hiding this comment.
why not filter on an array of strings? I think it's simpler and needs less code
dvaldivia
requested changes
Jun 23, 2021
| setLoadingUsers(false); | ||
| }) | ||
| .catch((err) => { | ||
| console.log("Error in loading users"); |
There was a problem hiding this comment.
display the error when loading users.
also se setLoadingUsers(false); on error
| email: string; | ||
| is_me: boolean; | ||
| enabled: boolean; | ||
| name?: string; |
There was a problem hiding this comment.
is this change still needed?
dvaldivia
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding filtering to Users on Policy Details