Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pod Security Standard label is set as annotation instead of label #746

Closed
netthier opened this issue Mar 31, 2023 · 1 comment · Fixed by #747
Closed

Pod Security Standard label is set as annotation instead of label #746

netthier opened this issue Mar 31, 2023 · 1 comment · Fixed by #747

Comments

@netthier
Copy link

netthier commented Mar 31, 2023

Describe the bug
When installing DirectPV 4.0.2 via the CLI (kubectl directpv install), a directpv namespace gets created.
If a pod security standard is enforced in the cluster, no containers will start as they lack dont conform to those standards.
To fix this, the namespace should be labelled with pod-security.kubernetes.io/enforce: privileged.
Someone seems to have already noticed that, as exactly that already exists as an annotation, which is however incorrect.
https://kubernetes.io/docs/tasks/configure-pod-container/enforce-standards-namespace-labels/

To Reproduce
Install DirectPV via kubectl directpv install with a Pod Security Standard being enforced in the cluster.

Expected behavior
I expect the namespace to be labelled as described above

Screenshots and logs
image
The annotation here should be a label instead.

Deployment information (please complete the following information):

  • DirectPV version: 4.0.2
  • Kubernetes Version: 1.26.3
  • OS info: N/A
  • Kernel version: N/A
balamurugana added a commit to balamurugana/directpv that referenced this issue Mar 31, 2023
Fixes minio#746

Signed-off-by: Bala.FA <bala@minio.io>
@balamurugana
Copy link
Member

Please check the PR #747

Praveenrajmani pushed a commit that referenced this issue Apr 4, 2023
Fixes #746

Signed-off-by: Bala.FA <bala@minio.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants