Add missing TypeMeta in --dry-run while syncing CRDs and bugfixes
#244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveenrajmani
commented
May 20, 2021
Praveenrajmani
commented
May 20, 2021
Praveenrajmani
changed the title
--dry-run while syncing CRDs and bigfixes--dry-run while syncing CRDs and bugfixes
Praveenrajmani
force-pushed
the
minor-dryrun-fixes
branch
from
a773fb3
to
a0a0ba2
Compare
- Avoid globals and read the conversion CA bundle from secret (not for `--dry-run` mode) - Add `TypeMeta` while syncing CRDs during upgrade - Add missing cleanups during uninstall
Praveenrajmani
force-pushed
the
minor-dryrun-fixes
branch
from
a0a0ba2
to
f3036e0
Compare
|
Will send seperate PRs for the fixes we make in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeMetawhile syncing CRDs during upgrade [For reference - https://github.com/Object's TypeMeta is empty kubernetes/client-go#413]