Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add volume scheduling documentation #739

Merged
merged 1 commit into from Mar 31, 2023

Conversation

balamurugana
Copy link
Member

Fixes #318

Fixes minio#318

Signed-off-by: Bala.FA <bala@minio.io>
@Praveenrajmani
Copy link
Collaborator

Do we need a "trouble shooting" section for volume scheduling issues? Like, for eg, if they see issues like "no drive found for requested topology" in the respective pods, we can convey that the the node isn't added (or) the requested size is more etc

@ravindk89
Copy link
Contributor

Do we need a "trouble shooting" section for volume scheduling issues? Like, for eg, if they see issues like "no drive found for requested topology" in the respective pods, we can convey that the the node isn't added (or) the requested size is more etc

It's not a bad idea, but that also largely depends on how common and predictable certain errors are - and how much work it is to maintain that.

But maybe a handful of the most likely suspects (No drives on the node where the pod is scheduled is a good one).
If we go that route though I'd argue we need error codes, not just error messages, to make it easier to do lookups. Otherwise you do string-type matches which can change over time.

@balamurugana
Copy link
Member Author

I am thinking docs restructure like below

  • installation

    • plugin
      • krew users
      • direct binary users
    • DirectPV
      • default installation
      • customized installation
        • KUBELET_DIR_PATH env var
        • node selector
        • tolerations
  • upgrade existing installation

    • plugin
    • DirectPV
      • from v4.x.x
      • from v3.x.x
      • from v2.x.x
  • usage guide

    • Add/List/Update/Delete drives
    • Add/List/Update/Delete volumes
  • troubleshooting

    • installation issues
      • plugin
      • DirectPV
    • upgrade issues
      • plugin
      • DirectPV
    • Add/List/Update/Delete drives issues
    • Add/List/Update/Delete volumes issues
  • architecture

    • plugin
    • DirectPV
  • developer guide

I think we would need to address many things than patching this PR

@Praveenrajmani
Copy link
Collaborator

^^ @ravindk89 @djwfyi let me know your thoughts ^^

@djwfyi
Copy link
Contributor

djwfyi commented Mar 29, 2023

That doc structure seems reasonable to me, @Praveenrajmani . It covers the major types of docs users would need.

@Praveenrajmani
Copy link
Collaborator

Can we take this PR and work on the other changes on top? @ravindk89 @djwfyi

@ravindk89
Copy link
Contributor

You have complete agency @Praveenrajmani on the scope here :)

Copy link
Collaborator

@Praveenrajmani Praveenrajmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, We can take this in and restructure the docs later

@ravindk89
Copy link
Contributor

Entirely reasonable approach. Go for it

@Praveenrajmani Praveenrajmani merged commit 7ed0aea into minio:master Mar 31, 2023
26 checks passed
@balamurugana balamurugana deleted the fix-issue-318 branch March 31, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document volume scheduling (ref: https://github.com/minio/direct-csi/issues/317)
4 participants