Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Helm operator #824

Merged
merged 2 commits into from Aug 29, 2023
Merged

Add Helm operator #824

merged 2 commits into from Aug 29, 2023

Conversation

cniackz
Copy link
Contributor

@cniackz cniackz commented Aug 15, 2023 •
edited

@cniackz cniackz self-assigned this Aug 15, 2023
@cniackz cniackz added the certification for any given certification label Aug 15, 2023
balamurugana
balamurugana reviewed Aug 16, 2023
View reviewed changes
Copy link
Member

@balamurugana balamurugana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use helm from https://github.com/minio/directpv/tree/master/helm

@cniackz
Copy link
Contributor Author

cniackz commented Aug 16, 2023

Sure @balamurugana I will be using helm from https://github.com/minio/directpv/tree/master/helm but also I need to test a little bit more prior the review. I will let you know when I am ready for the review.

@cniackz
Copy link
Contributor Author

cniackz commented Aug 16, 2023

Two things:

  1. Using the helm chart added previously, just moved from location.
  2. Using latest tag 4.0.7 for the current Operator
  3. Tested truly in k8s to deploy operator and install directpv

I think this is ready for another round of reviews.

balamurugana
balamurugana reviewed Aug 17, 2023
View reviewed changes
helm/Makefile Outdated Show resolved Hide resolved
helm/Makefile Show resolved Hide resolved
helm/PROJECT Outdated Show resolved Hide resolved
helm/README.md Outdated Show resolved Hide resolved
helm/my-directpv.yaml Outdated Show resolved Hide resolved
helm/pvc.yaml Outdated Show resolved Hide resolved
@cniackz
Copy link
Contributor Author

cniackz commented Aug 17, 2023

Waiting for tests to pass, then I will ask another round of reviews.

balamurugana
balamurugana reviewed Aug 18, 2023
View reviewed changes
helm/generate.sh Outdated Show resolved Hide resolved
helm/generate.sh Outdated Show resolved Hide resolved
helm/generate.sh Outdated Show resolved Hide resolved
@cniackz
Copy link
Contributor Author

cniackz commented Aug 18, 2023

Waiting for tests to pass, then I will ask another round of reviews.

balamurugana
balamurugana previously approved these changes Aug 19, 2023
View reviewed changes
@balamurugana balamurugana changed the title Adding Helm Operator Add Helm operator Aug 19, 2023
Praveenrajmani
Praveenrajmani reviewed Aug 21, 2023
View reviewed changes
helm/helm.sh Outdated Show resolved Hide resolved
helm/examples/pvc.yaml Outdated Show resolved Hide resolved
@cniackz
Copy link
Contributor Author

cniackz commented Aug 23, 2023

Waiting for tests to pass, then I ask for another review.

@cniackz
Copy link
Contributor Author

cniackz commented Aug 24, 2023

Failures are not related to this PR, look: #828

@Praveenrajmani Praveenrajmani merged commit ccdec4d into minio:master Aug 29, 2023
22 checks passed
@cniackz cniackz deleted the add-helm-operator-1 branch August 29, 2023 16:07
@djwfyi djwfyi mentioned this pull request Nov 15, 2023
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balamurugana balamurugana balamurugana approved these changes

@Praveenrajmani Praveenrajmani Praveenrajmani approved these changes

Assignees

@cniackz cniackz

Labels
certification for any given certification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cniackz @balamurugana @Praveenrajmani