Add commands for suspending and resuming drives and volumes #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveenrajmani
force-pushed
the
drive-suspension
branch
5 times, most recently
from
7ed713b
to
076bf88
Compare
| resumeVolumesCmd.PersistentFlags().SortFlags = false | ||
|
|
||
| addNodesFlag(resumeVolumesCmd, "If present, resume volumes from given nodes") | ||
| addDrivesFlag(resumeVolumesCmd, "If present, resume volumes by given drive names") |
There was a problem hiding this comment.
As these two flags are also available in resume_drives.go, you could add commonly to resume.go
There was a problem hiding this comment.
we can't have generic messages if we move it to resume.go like resume objects by given drive names
| suspendDrivesCmd.PersistentFlags().SortFlags = false | ||
|
|
||
| addNodesFlag(suspendDrivesCmd, "If present, suspend drives from given nodes") | ||
| addDrivesFlag(suspendDrivesCmd, "If present, suspend drives by given names") |
| addDrivesFlag(suspendVolumesCmd, "If present, suspend volumes by given drive names") | ||
| addPodNameFlag(suspendVolumesCmd, "If present, suspend volumes by given pod names") | ||
| addPodNSFlag(suspendVolumesCmd, "If present, suspend volumes by given pod namespaces") | ||
| addDangerousFlag(suspendVolumesCmd, "Suspending the volumes will make them as read-only") |
There was a problem hiding this comment.
We could add this flag to suspend.go
Praveenrajmani
force-pushed
the
drive-suspension
branch
from
076bf88
to
80e6a22
Compare
Praveenrajmani
force-pushed
the
drive-suspension
branch
from
80e6a22
to
2ab8026
Compare
balamurugana
approved these changes
Sep 20, 2023
Praveenrajmani
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #836