Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use streaming API for listing identities #129

Merged
merged 2 commits into from
Jun 4, 2021
Merged

use streaming API for listing identities #129

merged 2 commits into from
Jun 4, 2021

Conversation

aead
Copy link
Member

@aead aead commented May 26, 2021

This commit modifies the /v1/identity/list API
to respond a nd-json stream of identity<->policy
mappings instead of one (eventually large) json
object.

The /v1/identity/list API is now similar to
the /v1/key/list API.

With the streaming API, a client can iterate over
some/all identities while using just a constant
amount of memory.

This is a major breaking API change.

This commit modifies the `/v1/identity/list` API
to respond a nd-json stream of identity<->policy
mappings instead of one (eventually large) json
object.

The `/v1/identity/list` API is now similar to
the `/v1/key/list` API.

With the streaming API, a client can iterate over
some/all identities while using just a constant
amount of memory.

This is a major breaking API change.

Signed-off-by: Andreas Auernhammer <aead@mail.de>
@aead aead requested a review from Alevsk May 26, 2021 10:39
Copy link
Contributor

@Alevsk Alevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aead aead merged commit 984966c into master Jun 4, 2021
@aead aead deleted the list-identity branch June 4, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants