vault: improve usage of time.Timer
#388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aead
force-pushed
the
timer
branch
3 times, most recently
from
266d99d
to
a2c29e7
Compare
This commit improves the usage of `time.Timer` esp. within the Vault token renew and re-auth logic. It follows some recommendations from: https://go101.org/article/memory-leaking.html Ref: Real Memory Leaking Caused by Not Stopping time.Ticker Values Which Are Not Used Any More Further, this commit updates the Vault SDK dep from 1.5 to 1.9.2 and removes some deprecated API usages. Signed-off-by: Andreas Auernhammer <hi@aead.dev>
harshavardhana
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the usage of
time.Timeresp. within the Vault token renew and re-auth
logic.
It follows some recommendations from:
https://go101.org/article/memory-leaking.html
Ref: Real Memory Leaking Caused by Not Stopping
time.Ticker Values Which Are Not Used Any More
Further, this commit updates the Vault SDK dep
from 1.5 to 1.9.2 and removes some deprecated API
usages.