Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit sample YAML config for easier importing to web docs #442

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

feorlen
Copy link
Contributor

@feorlen feorlen commented Feb 12, 2024

Small edits to server-config.yaml to better match web docs style. This makes it easier to include a sample config in the KES docs.

Closes minio/docs#1123

@feorlen feorlen requested a review from djwfyi February 12, 2024 23:25
@feorlen
Copy link
Contributor Author

feorlen commented Feb 12, 2024

@djwfyi adding you as reviewer to confirm edits before additional approvals.

djwfyi
djwfyi previously approved these changes Feb 13, 2024
Copy link

@djwfyi djwfyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One singular/plural mashup I want to figure out how to rephrase, the rest LGTM.

server-config.yaml Outdated Show resolved Hide resolved
@feorlen
Copy link
Contributor Author

feorlen commented Feb 13, 2024

@aead When you have a moment, appreciate a review of the edited comments in the example server-config.yaml file. Nothing should have changed in the meaning, only a bit better match to the web docs style so it's easier to copy into docs. Thanks!

@aead aead merged commit 14408fb into minio:master Feb 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update KES config examples based on Daryl's edits
3 participants