Inspect to return a new format #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
requested changes
Aug 4, 2022
vadmeste
force-pushed
the
always-encrypt-inspect-data
branch
from
c4224da
to
3ddda18
Compare
harshavardhana
requested changes
Sep 5, 2022
With the new inspect model, the data will be encrypted with a public key. The exisiting symmetric key is not needed anymore, but this API will still support it. If a public key is specified in the API, use a POST request with multipart form data to upload all data, otherwise use the old style. Return a nil key if the public key is provided since the caller will be able to decrypt data with his private key.
vadmeste
force-pushed
the
always-encrypt-inspect-data
branch
from
3ddda18
to
a90536a
Compare
harshavardhana
requested changes
Sep 29, 2022
There was a problem hiding this comment.
I see some discussions still on this?, is this finalized? @vadmeste
// cc @klauspost
klauspost
added a commit
to klauspost/madmin-go
that referenced
this pull request
Oct 12, 2022
|
Not needed anymore, superseded by #133 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return format version in addition to the existing API to
interpret the inspect data correctly.