session: Close data session file when migrating (#2126)

Cleanup needed before removing the data file
minio · Apr 18, 2017 · 656f4f1 · 656f4f1
1 parent 9eb967c
commit 656f4f1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/cmd/session-main.go b/cmd/session-main.go
@@ -134,7 +134,7 @@ func clearSession(sid string) {
 			session, err := loadSessionV8(sid)
 			fatalIf(err.Trace(sid), "Unable to load session `"+sid+"`.")
 
-			fatalIf(session.Delete().Trace(sid), "Unable to load session `"+sid+"`.")
+			fatalIf(session.Delete().Trace(sid), "Unable to remove session `"+sid+"`.")
 
 			printMsg(clearSessionMessage{Status: "success", SessionID: sid})
 		}
@@ -156,7 +156,7 @@ func clearSession(sid string) {
 	}
 
 	if session != nil {
-		fatalIf(session.Delete().Trace(sid), "Unable to load session `"+sid+"`.")
+		fatalIf(session.Delete().Trace(sid), "Unable to remove session `"+sid+"`.")
 		printMsg(clearSessionMessage{Status: "success", SessionID: sid})
 	}
 }

diff --git a/cmd/session-migrate.go b/cmd/session-migrate.go
@@ -37,6 +37,9 @@ func migrateSessionV7ToV8() {
 			fatalIf(err.Trace(sid), "Unable to load version `7`. Migration failed please report this issue at https://github.com/minio/mc/issues.")
 		}
 
+		// Close underlying session data file.
+		sV7.DataFP.Close()
+
 		sessionVersion, e := strconv.Atoi(sV7.Header.Version)
 		fatalIf(probe.NewError(e), "Unable to load version `7`. Migration failed please report this issue at https://github.com/minio/mc/issues.")
 		if sessionVersion > 7 { // It is new format.