New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mc should respect "Set-Cookie" headers and provide the Cookie in requests #2610
Comments
This is not part of S3 standard - mc is an S3 client - can you provide S3 documentation regarding this ? Or any other S3 clients which support this behavior ? |
It might not be part of the S3 standard -- I don't know. But honestly, with that reasoning there's no need to have the It's common functionality in HTTP servers/clients (https://tools.ietf.org/html/rfc2965) and since S3 wouldn't send any Feel free to close if you don't think it's a valid feature. Thanks for considering it. |
yes, |
The reason why I suggested is that it's a normal thing for load balancers to do to route traffic to the same instance. E.g. you have HAProxy in front of your minio cluster and then HAProxy injects the cookie to keep clients pinned to one server. |
This required a change in minio-go PR already sent minio/minio-go#1054 |
Thanks a lot, @harshavardhana! Much appreciated. :) |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Expected behavior
mc
should respectSet-Cookie
headers in responses. When using a reverse proxy that uses sticky sessions based on Cookies,mc
should provide this cookie back to the proxy for ensure the proxy/load balancer can properly persist the session.Actual behavior
mc --debug
shows that the proxy/loadbalancer sends theSet-Cookie
header in the response, but doesn't attach the cookie on the next request.Steps to reproduce the behavior
mc --debug
to see that theSet-Cookie
header is ignoredmc version
System information
N/A
The text was updated successfully, but these errors were encountered: