Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendorize minio-go to version 4.0.6 #2357

Merged
merged 1 commit into from Jan 16, 2018
Merged

vendorize minio-go to version 4.0.6 #2357

merged 1 commit into from Jan 16, 2018

Conversation

poornas
Copy link
Contributor

@poornas poornas commented Jan 13, 2018

Fixes #2304
minio-go increases # of retries to 10 in 4.0.6 release. This might help with connection timeouts.

minio-go changes from 4.0.5 to 4.0.6 release

@codecov-io
Copy link

codecov-io commented Jan 13, 2018

Codecov Report

Merging #2357 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2357      +/-   ##
==========================================
- Coverage   10.82%   10.82%   -0.01%     
==========================================
  Files         103      103              
  Lines        7676     7678       +2     
==========================================
  Hits          831      831              
- Misses       6711     6713       +2     
  Partials      134      134
Impacted Files Coverage Δ
cmd/client-s3.go 13.32% <0%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f2f82b...4e695c8. Read the comment docs.

Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps you can list out the changes from the previous update in a

git rel 8f3697672e0e9246e8ab65108f2b7b1294814294..4.0.6

style? from minio-go repository.

@@ -228,5 +228,5 @@
"revisionTime": "2015-07-29T10:04:31+02:00"
}
],
"rootPath": "github.com/minio/mc"
"rootPath": "github.com/minio/mc-clone"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is your rootPath wrong? please fix.

@nitisht nitisht merged commit 5d703df into minio:master Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mc gives timeout problem
5 participants