add bucket tagging support

[balamurugana]

depends on minio/minio-go#1281 #3212

[balamurugana]

I get the following errors after pulling the 3 related PRs (minio, minio-go & mc). The errors are in mc code base.

No wonder of failure unless respective base PRs are fixed and merged. I would recommend to test base PRs than higher level PRs

[kannappanr]

@balamurugana Can you PTAL at the build failure? Does this PR depend on minio/minio-go#1273 as minio/minio-go#1279 has been merged and included in go.mod?

[balamurugana]

@balamurugana Can you PTAL at the build failure? Does this PR depend on minio/minio-go#1273 as minio/minio-go#1279 has been merged and included in go.mod?

The PR depends on minio/minio-go#1273

[BigUstad]

1. Please refer fixed: copy-object tagging-directive REPLACE with no tags minio#9477. This same bug is present.

2. Indentation is absent:
   $ mc tag list prihome9001/bkt1/smear-oil-casserole-dish_4.jpg
   datetime: 04/30/20_22:23:23
   confidentiality: open-to-authenticated-only
   editable: only-by-owner-and-authenticated
   designation1: value1

3. No message for tag not set.
   $ mc tag list prihome9001/bkt1/smear-oil-casserole-dish_3.jpg

4. Conflicting output message
   $ mc tag remove prihome9001/bkt1/
   mc: Unable to remove tags for prihome9001/bkt1/ We encountered an internal error, please try again.
   Tags removed for prihome9001/bkt1/.
   $ mc tag remove s3/pribkt6
   mc: Unable to remove tags for s3/pribkt6 The specified bucket does not exist
   Tags removed for s3/pribkt6.

[balamurugana]

1. Please refer [minio/minio#9477](https://github.com/minio/minio/issues/9477). This same bug is present.

I removed getCpObjTagsFromHeader() and am using the logic directly.

[balamurugana]

2\. Indentation is absent:

Fixed. Also note that the difference in output.

3\. No message for tag not set.

Two different behaviour in AWS S3. For buckets, it returns below error, but objects it returns success with no tags.

<?xml version="1.0" encoding="UTF-8"?>                                                                                                             
<Error><Code>NoSuchTagSet</Code><Message>The TagSet does not exist</Message><BucketName>bala-test-bucket1</BucketName><RequestId>35834BE42705186B</RequestId><HostId>VzUofcmRRhYyjQkmWc7X5tRsgZWgui57S0HocPyKayydaLR4f9Ya0cRmVVfKNwO+XktqBvMi4go=</HostId></Error>

I have introduced to print an error message returned like S3, but --debug shows success.

4\. Conflicting output message

mc tag remove should behave like below

[bala@localhost mc]$ ./mc -C ~/.mc tag remove s3/bala-test-bucket1
Tags removed for s3/bala-test-bucket1.
[bala@localhost mc]$ ./mc -C ~/.mc tag remove s3/bala-test-bucket1
Tags removed for s3/bala-test-bucket1.
[bala@localhost mc]$ ./mc -C ~/.mc tag remove s3/bala-test-bucket1/zero
Tags removed for s3/bala-test-bucket1/zero.
[bala@localhost mc]$ ./mc -C ~/.mc tag remove s3/bala-test-bucket1/zero
Tags removed for s3/bala-test-bucket1/zero.
[bala@localhost mc]$ 

[kannappanr]

LGTM

[kannappanr]

Output currently is

$ mc tag list myminio/vvertica/issue
Name                :    issue
datetime            :    2020Mar96TS120000
editable            :    only-by-owner-and-authenticated
confidentiality     :    open-to-authenticated-only

with this PR it is

$ mc tag list myminio/vvertica/issue
confidentiality : open-to-authenticated-only
datetime        : 2020Mar96TS120000
editable        : only-by-owner-and-authenticated

it is missing the name of the object being displayed. Can that be added back with the same color?

[balamurugana]

it is missing the name of the object being displayed. Can that be added back with the same color?

I removed it on purpose because the command fetches only one entity at once and Name : issue is a confusion which is mixed with tags in the output.

Another interesting case is an user can have tag key as Name and the output would ended up with a surprise.

[BigUstad]

LGTM

[kannappanr]

@balamurugana We followed the mc stat style

 $ mc stat play/test/issue
Name      : issue
Date      : 2020-05-04 13:41:03 PDT 
Size      : 26 B   
ETag      : b954418e6a50d4d4cb8f02776d867550 
Type      : file 
Metadata  :
  X-Amz-Meta-Mc-Attrs                : atime:1588604789/ctime:1559178264/gid:0/gname:root/mode:33188/mtime:1549351932/uid:0/uname:root 
  X-Amz-Object-Lock-Mode             : GOVERNANCE 
  Content-Type                       : application/octet-stream 
  X-Amz-Object-Lock-Retain-Until-Date: 2020-05-05T20:41:03Z 
Encrypted :
  X-Amz-Server-Side-Encryption: AES256 

The one in the top is in different color and you will not see that in json format. Not sure what is the cause for confusion.

[harshavardhana]

@balamurugana #3212 please take some changes from this PR including fixes for

• support autocompletion
• non-idiomatic usage of probe.NewError
• error messages and indentation in help messages etc.

[balamurugana]

The one in the top is in different color and you will not see that in json format. Not sure what is the cause for confusion.

Name is added back like stat output.

[kannappanr]

LGTM