Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "cli: Load global flags in initBeforeRunningCmd (#3283)" #3302

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Revert "cli: Load global flags in initBeforeRunningCmd (#3283)" #3302

merged 1 commit into from
Jul 16, 2020

Conversation

harshavardhana
Copy link
Member

No description provided.

@harshavardhana harshavardhana force-pushed the dont-override branch 2 times, most recently from a08bad5 to 90fc155 Compare July 16, 2020 09:22
@harshavardhana
Copy link
Member Author

This PR also fixes all the broken tests after 712ff33 change

klauspost
klauspost approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vadmeste
vadmeste reviewed Jul 16, 2020
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, also what does the PR fix ?

cmd/config-host.go Outdated Show resolved Hide resolved
@harshavardhana
Copy link
Member Author

One comment, also what does the PR fix ?

https://subnet.min.io/support/957 this and @vadmeste and the changes in this PR are needed without them mc functional tests are not running and have been broken since 712ff33

@harshavardhana harshavardhana force-pushed the dont-override branch 9 times, most recently from c870812 to e3475b8 Compare July 16, 2020 16:50
@harshavardhana harshavardhana changed the title don't override config once set Revert "cli: Load global flags in initBeforeRunningCmd (#3283)" Jul 16, 2020
vadmeste
vadmeste approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kannappanr
kannappanr approved these changes Jul 16, 2020
View reviewed changes
Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 0b0acc6 into minio:master Jul 16, 2020
@harshavardhana harshavardhana deleted the dont-override branch July 16, 2020 18:10
@harshavardhana harshavardhana mentioned this pull request Jul 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadmeste vadmeste vadmeste approved these changes

@klauspost klauspost klauspost approved these changes

@kannappanr kannappanr kannappanr approved these changes

@ebozduman ebozduman Awaiting requested review from ebozduman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@harshavardhana @vadmeste @klauspost @kannappanr