Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rb: Delete object versions as well #3322

Merged
merged 6 commits into from
Aug 3, 2020
Merged

Conversation

vadmeste
Copy link
Member

Ready but we need to validate this requirement.

Dangerous for users since it is removing all versions as well.

Maybe we can add a confirmation prompt here, or a flag --with-versions.

@vadmeste vadmeste marked this pull request as ready for review August 1, 2020 17:45
cmd/rb-main.go Outdated Show resolved Hide resolved
cmd/rb-main.go Outdated Show resolved Hide resolved
docs/minio-client-complete-guide.md Outdated Show resolved Hide resolved
docs/minio-client-complete-guide.md Outdated Show resolved Hide resolved
@harshavardhana
Copy link
Member

Dangerous for users since it is removing all versions as well.

If they need to preserve the bucket they should be using object-locking @vadmeste

vadmeste and others added 6 commits August 3, 2020 21:17
Co-authored-by: Harshavardhana <harsha@minio.io>
Co-authored-by: Harshavardhana <harsha@minio.io>
Co-authored-by: Harshavardhana <harsha@minio.io>
Co-authored-by: Harshavardhana <harsha@minio.io>
Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit b1aa159 into minio:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants