Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move version commands to top level #3329

Merged
merged 1 commit into from Jul 30, 2020
Merged

Move version commands to top level #3329

merged 1 commit into from Jul 30, 2020

Conversation

poornas
Copy link
Contributor

@poornas poornas commented Jul 30, 2020

moving mc bucket version to mc version - subcommands come before the target.

kannappanr
kannappanr approved these changes Jul 30, 2020
View reviewed changes
Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr requested a review from BigUstad July 30, 2020 00:53
@harshavardhana
Copy link
Member

harshavardhana commented Jul 30, 2020 •
edited

Can we do this in a single PR @poornas @kannappanr ? all commands?

BigUstad
BigUstad approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@BigUstad BigUstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested.

@kannappanr kannappanr merged commit 7ffa755 into minio:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigUstad BigUstad BigUstad approved these changes

@kannappanr kannappanr kannappanr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@poornas @harshavardhana @BigUstad @kannappanr