Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versioning support for rm cmd #3339

Merged
merged 7 commits into from
Aug 10, 2020
Merged

Conversation

vadmeste
Copy link
Member

@vadmeste vadmeste commented Aug 4, 2020

Add versioning support of rm command

--version to specify a specific version id of an object when removing
--versions includes older versions along with objects
--rewind go back in time before removing

@harshavardhana
Copy link
Member

The exact specification is not approved yet.

Currently:
--version to specify a specific version id of an object when removing
--versions includes versions along with objects
--rewind go back in time before removing

can we not do mc ls style for deletions? mc rm alias/bucket/object:1 ? instead of --version id?

@vadmeste vadmeste changed the title rm: Add versioning support Add versioning support for rm and stat commands Aug 5, 2020
@vadmeste
Copy link
Member Author

vadmeste commented Aug 5, 2020

can we not do mc ls style for deletions? mc rm alias/bucket/object:1 ? instead of --version id?

The spec is changed, now we use --version-id style and mc ls will print version ids as well.

The reason is that ':0' notation is not static and can change (:0 means the latest version, :1 means the second latest version, etc..)

@vadmeste vadmeste changed the title Add versioning support for rm and stat commands Add versioning support for rm command Aug 5, 2020
@vadmeste vadmeste changed the title Add versioning support for rm command Add versioning support for rm cmd Aug 5, 2020
@vadmeste vadmeste marked this pull request as ready for review August 5, 2020 20:28
cmd/rm-main.go Outdated Show resolved Hide resolved
cmd/rm-main.go Outdated Show resolved Hide resolved
cmd/rm-main.go Outdated Show resolved Hide resolved
Copy link
Contributor

@poornas poornas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs updates to docs

@vadmeste
Copy link
Member Author

vadmeste commented Aug 8, 2020

needs updates to docs

@poornas the documentation is updated.

vadmeste and others added 4 commits August 8, 2020 10:51
Co-authored-by: Harshavardhana <harsha@minio.io>
Co-authored-by: Harshavardhana <harsha@minio.io>
Co-authored-by: Harshavardhana <harsha@minio.io>
cmd/rm-main.go Outdated Show resolved Hide resolved
docs/minio-client-complete-guide.md Outdated Show resolved Hide resolved
vadmeste and others added 2 commits August 10, 2020 09:01
Co-authored-by: poornas <poornas@users.noreply.github.com>
Copy link
Contributor

@poornas poornas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit 6313ee7 into minio:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants