Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change admin bucket remote cli args #3340

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Change admin bucket remote cli args #3340

merged 1 commit into from
Aug 7, 2020

Conversation

poornas
Copy link
Contributor

@poornas poornas commented Aug 5, 2020 •
edited 

Before:  $ mc admin bucket remote set myminio/srcbucket https://foobar:foo12345@minio2:9000/replicabucket --type "replica"
After:   $ mc admin bucket remote set  myminio/srcbucket https://foobar:foo12345@minio2:9000/replicabucket --service "replication"

Before:  $ mc admin bucket remote remove myminio/srcbucket --arn "arn:minio:replica::993bc6b6-accd-45e3-884f-5f3e652aed2a:dest1"
After:   $ mc admin bucket remote rm  "arn:minio:replica::993bc6b6-accd-45e3-884f-5f3e652aed2a:dest1" myminio/srcbucket

Before:  $ mc admin bucket remote list myminio/srcbucket --type "replica"
After:   $ mc admin bucket remote ls myminio/srcbucket --service "replication"

@poornas poornas force-pushed the remote branch 2 times, most recently from d270e0d to e161e07 Compare August 5, 2020 15:48
vadmeste
vadmeste reviewed Aug 5, 2020
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment

cmd/admin-bucket-remote-rm.go Outdated Show resolved Hide resolved
@poornas poornas mentioned this pull request Aug 6, 2020
Merged
6 tasks
@poornas poornas force-pushed the remote branch 8 times, most recently from 1050498 to 9a60bc2 Compare August 7, 2020 15:54
Change admin bucket remote cli args
02ca89d 
Add support to list all remote targets for a tenant
kannappanr
kannappanr approved these changes Aug 7, 2020
View reviewed changes
Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit 0ba1633 into minio:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadmeste vadmeste vadmeste left review comments

@kannappanr kannappanr kannappanr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@poornas @vadmeste @kannappanr