Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ilm set as ilm edit #3420

Merged
merged 1 commit into from Nov 23, 2020
Merged

Rename ilm set as ilm edit #3420

merged 1 commit into from Nov 23, 2020

Conversation

poornas
Copy link
Contributor

@poornas poornas commented Sep 25, 2020

Use label set in mc admin bucket remote add as storage-class for transition

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

cmd/ilm-add.go Outdated Show resolved Hide resolved
docs/minio-client-complete-guide.md Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
Copy link
Contributor

@BigUstad BigUstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested

Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr
Copy link
Collaborator

@poornas Please resolve the conflicts

@poornas
Copy link
Contributor Author

poornas commented Nov 5, 2020

needs minio/minio#10565 to merge first for pkg/madmin changes.

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo, LGTM otherwise

cmd/ilm-add.go Outdated Show resolved Hide resolved
@poornas poornas force-pushed the transition branch 2 times, most recently from 741cbbe to ff06c4d Compare November 5, 2020 17:52
@poornas poornas force-pushed the transition branch 2 times, most recently from a479f80 to aa7481a Compare November 12, 2020 20:30
Add examples of ilm command with transition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants