Now newReq() doesn't panic inside, returns err properly - use iodine #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
pr_out_now_newreq_doesn_t_panic_inside_returns_err_properly_use_iodine
branch
from
7389d49
to
d37fd4d
Compare
harshavardhana
force-pushed
the
pr_out_now_newreq_doesn_t_panic_inside_returns_err_properly_use_iodine
branch
from
d37fd4d
to
b96b9cc
Compare
harshavardhana
force-pushed
the
pr_out_now_newreq_doesn_t_panic_inside_returns_err_properly_use_iodine
branch
from
b96b9cc
to
d38b93a
Compare
|
LGTM |
harshavardhana
pushed a commit
that referenced
this pull request
Apr 17, 2015
…_panic_inside_returns_err_properly_use_iodine
harshavardhana
deleted the
pr_out_now_newreq_doesn_t_panic_inside_returns_err_properly_use_iodine
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.