Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove quota FIFO support #3942

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Conversation

harshavardhana
Copy link
Member

No description provided.

@harshavardhana harshavardhana requested review from poornas, vadmeste, kannappanr and krisis and removed request for poornas January 28, 2022 19:19
@mshanmu
Copy link

mshanmu commented Jan 28, 2022

@harshavardhana , This is very important feature. I would dare say a key differentiator. Any reason on why it is being removed?

@harshavardhana
Copy link
Member Author

@harshavardhana , This is very important feature. I would dare say a key differentiator. Any reason on why it is being removed?

You need to use ILM instead of FIFO for expiring old content - this is not an important feature for any of our customers and it is not optimal.

If you are an active customer please reach out to https://subnet.min.io if not we are removing this.

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments

cmd/admin-bucket-quota.go Outdated Show resolved Hide resolved
cmd/admin-bucket-quota.go Outdated Show resolved Hide resolved
@mshanmu
Copy link

mshanmu commented Jan 31, 2022

@harshavardhana , This is very important feature. I would dare say a key differentiator. Any reason on why it is being removed?

You need to use ILM instead of FIFO for expiring old content - this is not an important feature for any of our customers and it is not optimal.

If you are an active customer please reach out to https://subnet.min.io if not we are removing this.

@harshavardhana , Thanks for the reply !! IMO, they are not equivalent, functionality-wise. With FIFO support, MinIO automatically takes cares of deleting the oldest files as the bucket usage reaches the bucket quota limits. With an ILM rule, the user cannot specify that the oldest files in the bucket to be automatically deleted as the bucket usage reaches the bucket quota limits. Please correct me if I am wrong.

Btw, another suggestion, please create an issue so that users will be aware that this feature is being removed.

@harshavardhana
Copy link
Member Author

@harshavardhana , This is very important feature. I would dare say a key differentiator. Any reason on why it is being removed?

You need to use ILM instead of FIFO for expiring old content - this is not an important feature for any of our customers and it is not optimal.

If you are an active customer please reach out to https://subnet.min.io if not we are removing this.

@harshavardhana , Thanks for the reply !! IMO, they are not equivalent, functionality-wise. With FIFO support, MinIO automatically takes cares of deleting the oldest files as the bucket usage reaches the bucket quota limits. With an ILM rule, the user cannot specify that the oldest files in the bucket to be automatically deleted as the bucket usage reaches the bucket quota limits. Please correct me if I am wrong.

ILM rule already provides necessary control. You can specifically set days based expiration on various prefixes.

We will be adding space based ILM expiration as an extension to S3 API in future.

FIFO in it's current form is broken, it doesn't work with really large namespaces where potentially crashes the server.

adfost pushed a commit to adfost/mc that referenced this pull request Oct 28, 2022
@parkjeongryul
Copy link

I've read the ILM document, and it seems that FIFO quata cannot be replaced.

If I want to delete old buckets by specifying a size (like 10Gi) as threshold instead of specific date, how can i replace it with ILM?

Is there a way to do this using ILM?

@harshavardhana
Copy link
Member Author

I've read the ILM document, and it seems that FIFO quata cannot be replaced.

If I want to delete old buckets by specifying a size (like 10Gi) as threshold instead of specific date, how can i replace it with ILM?

Is there a way to do this using ILM?

Size based ILM will come in future, no ETA yet.

@minio minio locked and limited conversation to collaborators Dec 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants