Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to print mc rm dry run message #4033

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Make sure to print mc rm dry run message #4033

merged 1 commit into from
Apr 1, 2022

Conversation

poornas
Copy link
Contributor

@poornas poornas commented Mar 31, 2022

No description provided.

harshavardhana
harshavardhana requested changes Mar 31, 2022
View reviewed changes
Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a versioned bucket this won't make sense what will dry-run show for a versioned bucket ?

@kannappanr
Copy link
Collaborator

On a versioned bucket this won't make sense what will dry-run show for a versioned bucket ?

$ mc rm play/test -r --dry-run --force
DRYRUN: Removing  /test/policy.json

$ mc rm play/test -r --dry-run --force --versions
DRYRUN: Removing  /test/policy.json version: null

$ mc rm play/testlock -r --dry-run --force  --versions
DRYRUN: Removing  /testlock/prefix/prefix/ version: 5dfd97b9-8028-4577-8303-fae4                                                                             6a293055
DRYRUN: Removing  /testlock/prefix/prefix/ version: 067ef3cd-a5a3-4bda-8499-c1f4                                                                             1d80153c
DRYRUN: Removing  /testlock/prefix/prefix/issue version: 4fbaf587-d8eb-4a96-9ed3                                                                             -c2b086ef3832

@poornas
Copy link
Contributor Author

poornas commented Apr 1, 2022

On a versioned bucket this won't make sense what will dry-run show for a versioned bucket ?
With versioned bucket, it is going to be like this

mc rm sitea/bucket -r --versions --force --fake 
DRYRUN: Removing  /bucket/copy-11536 version: 01e6438d-041a-46ee-af30-2c2319ae9fde
mc rm sitea/bucket -r  --force --fake 
DRYRUN: Removing  /bucket/copy-11536

@kannappanr kannappanr merged commit dc2a851 into minio:master Apr 1, 2022
adfost pushed a commit to adfost/mc that referenced this pull request Oct 28, 2022
@poornas @adfost
Make sure to print mc rm dry run message (minio#4033)
cbe2519 
Co-authored-by: Poorna Krishnamoorthy <poorna@minio.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana requested changes

@kannappanr kannappanr kannappanr approved these changes

@vadmeste vadmeste Awaiting requested review from vadmeste

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@poornas @kannappanr @harshavardhana