Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for --older/newer-than flags #4039

Merged
merged 12 commits into from
Apr 16, 2022

Conversation

ndoornekamp
Copy link
Contributor

@ndoornekamp ndoornekamp commented Apr 4, 2022

The current documentation for the --older-than and --newer-than flags suggests that the value for these flags should be an integer specifying a number of days, while it's expecting a duration string (e.g. 7d10h31s) instead.

The old documentation for the --older-than and --newer-than flags suggested that the value for these flags should be an integer specifying a number of days, while it should be a duration string (e.g. 7d10h31s).
@donatello
Copy link
Member

donatello commented Apr 7, 2022

Could you also update the help strings for in the go files @ndoornekamp ?

Copy link
Member

@donatello donatello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need changes to help strings in sources files too:

cmd/mv-main.go
40:			Name:  "older-than",
41-			Usage: "move objects older than L days, M hours and N minutes",
42-		},
--
44:			Name:  "newer-than",
45-			Usage: "move objects newer than L days, M hours and N minutes",
46-		},

cmd/rm-main.go
84:			Name:  "older-than",
85-			Usage: "remove objects older than L days, M hours and N minutes",
86-		},
--
88:			Name:  "newer-than",
89-			Usage: "remove objects newer than L days, M hours and N minutes",
90-		},

cmd/replicate-reset-start.go
37:		Name:  "older-than",
38-		Usage: "replicate back objects older than n days",
39-	},

cmd/mirror-main.go
100:			Name:  "older-than",
101-			Usage: "filter object(s) older than L days, M hours and N minutes",
102-		},
--
104:			Name:  "newer-than",
105-			Usage: "filter object(s) newer than L days, M hours and N minutes",
106-		},

cmd/find-main.go
48:			Name:  "newer-than",
49-			Usage: "match all objects newer than L days, M hours and N minutes",
50-		},
--
52:			Name:  "older-than",
53-			Usage: "match all objects older than L days, M hours and N minutes",
54-		},

cmd/cp-main.go
54:			Name:  "older-than",
55-			Usage: "copy objects older than L days, M hours and N minutes",
56-		},
--
58:			Name:  "newer-than",
59-			Usage: "copy objects newer than L days, M hours and N minutes",
60-		},

@ndoornekamp
Copy link
Contributor Author

@harshavardhana @donatello What's the next step for this? It looks like it's ready to be merged, but I'm not authorized to do that.

@harshavardhana harshavardhana merged commit 0530f5a into minio:master Apr 16, 2022
adfost pushed a commit to adfost/mc that referenced this pull request Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants