Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace fake with dry-run #4050

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Replace fake with dry-run #4050

merged 1 commit into from
Apr 14, 2022

Conversation

sinhaashish
Copy link
Contributor

@sinhaashish sinhaashish commented Apr 14, 2022 •
edited

Fake flag is deprecated . Use dry-run instead

anjalshireesh
anjalshireesh requested changes Apr 14, 2022
View reviewed changes
cmd/mirror-main.go Outdated Show resolved Hide resolved
anjalshireesh
anjalshireesh approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@anjalshireesh anjalshireesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 1a504e6 into minio:master Apr 14, 2022
@sinhaashish sinhaashish deleted the dry-run branch April 21, 2022 08:22
adfost pushed a commit to adfost/mc that referenced this pull request Oct 28, 2022
@sinhaashish @adfost
Replace fake with dry-run (minio#4050)
0d82cd9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anjalshireesh anjalshireesh anjalshireesh approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

@kannappanr kannappanr Awaiting requested review from kannappanr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sinhaashish @anjalshireesh @harshavardhana