mirror: Stop minio-go bucket listen when watch is cancelled #4053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When mirror in --watch mode is restarted, the previous minio-go ListenNotification/ListenBucketNotification call is not properly canceled. This commit creates a new context for that listen call and cancels it when client-s3 Watch() is asked to be stopped.
harshavardhana
approved these changes
Apr 15, 2022
|
IMO we should also fix server-side @vadmeste such that - we should not allow more than X amount of active Listen Notifications. |
Yes, 1024 looks a fair number |
Maybe we can do 1024 per node instead for bucket notification and 8 per node for tracing. |
Yeah that is an okay value but still high though. |
adfost
pushed a commit
to adfost/mc
that referenced
this pull request
Oct 28, 2022
When mirror in --watch mode is restarted, the previous minio-go ListenNotification/ListenBucketNotification call is not properly canceled. This commit creates a new context for that listen call and cancels it when client-s3 Watch() is asked to be stopped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When mirror in --watch mode is restarted, the previous minio-go
ListenNotification/ListenBucketNotification call is not properly
canceled. This commit creates a new context for that listen call and
cancels it when client-s3 Watch() is asked to be stopped.