mirror: Do not create remote bucket with --dry-run #4054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a site wide mirroring, non existing buckets in the destination site are still created if --dry-run is passed. This commit will avoid this. This commit also prints a mirror message of the newly created buckets in a site wide mirroring.
harshavardhana
approved these changes
Apr 15, 2022
adfost
pushed a commit
to adfost/mc
that referenced
this pull request
Oct 28, 2022
In a site wide mirroring, non existing buckets in the destination site are still created if --dry-run is passed. This commit will avoid this. This commit also prints a mirror message of the newly created buckets in a site wide mirroring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a site wide mirroring, non existing buckets in the destination site
are still created if --dry-run is passed. This commit will avoid this.
This commit also prints a mirror message of the newly created buckets
in a site wide mirroring.