Deprecate --name flag from support diag
#4092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier the `support diag` command used to work even when the cluster was not registered with SUBNET. In such cases, it used to pass the value of `--name` flag as the cluster name to be set on SUBNET. Now it errors out if the cluster is not registered. i.e. It expects the cluster to be already registered with SUBNET, which means it already has a name. Hence the `--name` flag is meaningless. Removing the code that used this flag, and marking it as hidden and deprecated.
anjalshireesh
force-pushed
the
support-diag
branch
from
b2c5a82
to
f69efcf
Compare
harshavardhana
approved these changes
May 19, 2022
sinhaashish
approved these changes
May 19, 2022
adfost
pushed a commit
to adfost/mc
that referenced
this pull request
Oct 28, 2022
Earlier the `support diag` command used to work even when the cluster was not registered with SUBNET. In such cases, it used to pass the value of `--name` flag as the cluster name to be set on SUBNET. Now it errors out if the cluster is not registered. i.e. It expects the cluster to be already registered with SUBNET, which means it already has a name. Hence the `--name` flag is meaningless. Removing the code that used this flag, and marking it as hidden and deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier the
support diagcommand used to work even when the clusterwas not registered with SUBNET. In such cases, it used to pass the value
of
--nameflag as the cluster name to be set on SUBNET.Now it errors out if the cluster is not registered. i.e. It expects the
cluster to be already registered with SUBNET, which means it already has
a name. Hence the
--nameflag is meaningless.Removing the code that used this flag, and marking it as hidden and
deprecated.