Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use showAppAndExit() for pager help #4292

Merged
merged 1 commit into from Oct 12, 2022
Merged

use showAppAndExit() for pager help #4292

merged 1 commit into from Oct 12, 2022

Conversation

harshavardhana
Copy link
Member

Description

use showAppAndExit() for pager help

Motivation and Context

this was missed in the pager help requirements

How to test this PR?

just type mc batch generate it should show help instead
it hangs the terminal, causing one to run 'reset'

// cc @vadmeste the issue in perhaps just calling

cli.ShowAppAndExist()

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

vadmeste
vadmeste reviewed Oct 11, 2022
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just gofumptd is needed

vadmeste
vadmeste approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 318569a into minio:master Oct 12, 2022
@harshavardhana harshavardhana deleted the batch-gen branch October 12, 2022 16:39
adfost pushed a commit to adfost/mc that referenced this pull request Oct 28, 2022
@harshavardhana @adfost
use showAppAndExit() for pager help (minio#4292)
1344e35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadmeste vadmeste vadmeste approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@harshavardhana @vadmeste