Restructure mc support callhome command
#4372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove `support logs enable|disable|status|show` - Make `support logs` behave like `support logs show` - Enhance `support callhome` to allow configuration of both periodic diagnostics and real-time log push with the same command - This will be achieved by adding two bool flags `--diag` and `--logs` - If none of these flags are passed, the action specified by the arg (enable|disable|status) will be performed for both the features
anjalshireesh
force-pushed
the
callhome
branch
from
fc9073f
to
e98fabc
Compare
harshavardhana
approved these changes
Nov 18, 2022
|
PTAL @vadmeste 🙏🏽 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
support logs enable|disable|status|showsupport logsbehave likesupport logs showsupport callhometo allow configuration of both periodic diagnostics and real-time log push with the same command--diagand--logsMotivation and Context
Group real-time logs and periodic diag push under the same umbrella of
callhomeHow to test this PR?
mc support callhome status {alias}should print status of both diag and logsmc support callhome enable {alias}should enable both diag and logsmc support callhome disable {alias}should disable both diag and logsmc support callhome status {alias} --[diag|logs]should print status of the given feature (diag/logs)mc support callhome enable {alias} --[diag|logs]should enable only the given feature (diag/logs)mc support callhome disable {alias} --[diag|logs]should disable only the given feature (diag/logs)Types of changes
Checklist:
commit-idorPR #here)