Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump up madmin-go to v2 #4382

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Bump up madmin-go to v2 #4382

merged 1 commit into from
Dec 1, 2022

Conversation

donatello
Copy link
Member

Description

Motivation and Context

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@donatello donatello requested review from harshavardhana and krisis and removed request for harshavardhana November 30, 2022 19:47
@donatello
Copy link
Member Author

Actually pkg needs to be updated first minio/pkg#49 so that we can stop depending on pre 2.0 versions of madmin-go in mc.

@harshavardhana
Copy link
Member

PTAL at the conflicts @donatello

@donatello
Copy link
Member Author

PTAL at the conflicts @donatello

Fixed!

@donatello donatello mentioned this pull request Dec 1, 2022
Merged
@harshavardhana harshavardhana merged commit 854b4f1 into minio:master Dec 1, 2022
@donatello donatello deleted the madmin branch December 1, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krisis krisis krisis approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@donatello @harshavardhana @krisis