Allow mirror to continue syncing after an object fails to sync #4427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
approved these changes
Jan 6, 2023
djwfyi
added a commit
to minio/docs
that referenced
this pull request
Jan 17, 2023
- Adds info on `mc mirror` continuing after a failed object sync [PR 4427](minio/mc#4427) - Adds addition call type to `mc admin trace` [PR 4416](minio/mc#4416) - Adds info about changed default file behavior for `mc support inspect` [PR 4420](minio/mc#4420) - Concurrent upload support for `mc pipe` [PR 4435](minio/mc#4435) - Renames two `mc admin replicate` subcommands [PR 4383](minio/mc#4383) - Updates behavior of `mc license update` to no longer require license file [PR 4429](minio/mc#4429) - New flag for `mc admin update` to bypass confirmation prompt [PR 4439](minio/mc#4427) There is no doc issue to track this update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, if
mc mirroris run without--overwrite, it will cancel the mirror if objects from the source also exist in the target. This changes the behavior so that an error is returned for the duplicate object, but the mirror continues with other objects, which is consistent with documentation.Motivation and Context
Fixes #4210
How to test this PR?
Types of changes
Checklist:
commit-idorPR #here)