Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rb: avoid throwing error for force delete of prefix #4436

Merged
merged 1 commit into from Jan 6, 2023

Conversation

poornas
Copy link
Contributor

@poornas poornas commented Jan 6, 2023

Description

Motivation and Context

Avoid throwing validation errors for prefix delete
With current master:
➜ bucket git:(master) ✗ mc ls sitea/bucket -r
[2023-01-06 10:52:50 PST] 0B STANDARD 18/
[2023-01-06 10:52:50 PST] 0B STANDARD 1oSHoFb8
➜ bucket git:(master) ✗ mc rb --force sitea/bucket/1oSHoFb8
mc: Failed to remove sitea/bucket/1oSHoFb8. Bucket name bucket/1oSHoFb8 not valid.

With this PR:
➜ mc git:(fxrb) mc rb --force sitea/bucket/1oSHoFb8
Removed sitea/bucket/1oSHoFb8 successfully.
➜ mc git:(fxrb) mc ls sitea/bucket -r
[2023-01-06 10:52:50 PST] 0B STANDARD 18/

How to test this PR?

try to delete prefix via mc rb --force

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@harshavardhana harshavardhana merged commit 55a9d20 into minio:master Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants