Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of giving a comment to service accounts #4438

Merged
merged 1 commit into from
Jan 14, 2023
Merged

Add support of giving a comment to service accounts #4438

merged 1 commit into from
Jan 14, 2023

Conversation

vadmeste
Copy link
Member

@vadmeste vadmeste commented Jan 9, 2023

Description

DEPENDS on minio/madmin-go#167

mc admin user svcacct add/edit will have a new flag
called --comment to associate a note to service accounts.

Users can use it to remember why a service account was created.

Motivation and Context

Add comment to service accounts

How to test this PR?

  1. Start a cluster
  2. ./mc admin user add myminio foo foo12345
  3. ./mc admin user svcacct add myminio foo --access-key "svc12345" --secret-key "svc1234567890" --comment "my comment"
  4. ./mc admin user svcacct info myminio svc12345

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

klauspost
klauspost approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but of course needs upstream.

@harshavardhana
Copy link
Member

Please resolve the conflicts @vadmeste

Add support of giving a comment to service accounts
f3ab1d1 
mc admin user svcacct add/edit will have a new flag called --comment to
associate a note to service accounts.

Users can use it to remember why a service account was created.
@vadmeste
Copy link
Member Author

Please resolve the conflicts @vadmeste

Done

@harshavardhana harshavardhana merged commit 6e97f16 into minio:master Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@klauspost klauspost klauspost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vadmeste @harshavardhana @klauspost