Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support --airgap in unregister command #4441

Merged
merged 3 commits into from
Jan 18, 2023
Merged

Support --airgap in unregister command #4441

merged 3 commits into from
Jan 18, 2023

Conversation

anjalshireesh
Copy link
Contributor

Description

When passed, the registration information will be removed from minio, without trying to unregister from subnet.

Motivation and Context

Can be useful when the clutser has already been removed from subnet by admin, or when the mc machine doesn't have connectivity to subnet.

How to test this PR?

  • Register a cluster using mc license register {alias}
  • Run mc license unregister {alias}
    • verify that the registered cluster is gone from subnet
    • verify that mc license info {alias} shows AGPL v3 license
  • Register the cluster again
  • Run mc license unregister {alias} --airgap
    • verify that the registered cluster is still present in subnet
    • verify that mc license info {alias} shows AGPL v3 license

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@anjalshireesh
Support --airgap in unregister command
401b064 
When passed, the registration information will be removed from minio,
without trying to unregister from subnet. Can be useful when the clutser
has already been removed from subnet by admin, or when the mc machine
doesn't have connectivity to subnet.
@anjalshireesh anjalshireesh marked this pull request as ready for review January 12, 2023 16:53
prakashsvmx
prakashsvmx approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. LGTM 👍

vadmeste
vadmeste approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 58f9fec into minio:master Jan 18, 2023
@anjalshireesh anjalshireesh deleted the unregister branch January 18, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadmeste vadmeste vadmeste approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

@prakashsvmx prakashsvmx prakashsvmx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@anjalshireesh @vadmeste @harshavardhana @prakashsvmx