Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve replicate ls output #4460

Merged
merged 1 commit into from Jan 31, 2023
Merged

Improve replicate ls output #4460

merged 1 commit into from Jan 31, 2023

Conversation

poornas
Copy link
Contributor

@poornas poornas commented Jan 31, 2023

Fixes : #4291

Description

Show relevant portion of the rules that are set and remote bucket

Motivation and Context

Remote target buckets can be identical - esp. in site replication. Show relevant endpoint of target and reduce UI clutter by showing only fields that are set.

How to test this PR?

Screenshot 2023-01-30 at 3 24 43 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@poornas poornas requested a review from vadmeste January 31, 2023 00:50
vadmeste
vadmeste approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit cb9de43 into minio:master Jan 31, 2023
@poornas poornas deleted the repl-ls branch February 17, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadmeste vadmeste vadmeste approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display arn:bucketname under mc replicate ls
3 participants
@poornas @vadmeste @harshavardhana