Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update mc admin doc #4529

Merged
merged 46 commits into from
Apr 17, 2023
Merged

doc: Update mc admin doc #4529

merged 46 commits into from
Apr 17, 2023

Conversation

dormanze
Copy link
Contributor

@dormanze dormanze commented Mar 29, 2023

Description

fix #4520 and update some admin doc

Motivation and Context

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@dormanze dormanze changed the title doc:Update mc admin policy doc:Update mc admin doc Mar 30, 2023
Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest of the changes look good.

docs/minio-admin-complete-guide.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ravindk89 ravindk89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

Long-term we probably will want to just link to the web docs and keep this as a simple list.

Copy link

@feorlen feorlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@djwfyi djwfyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

As @ravindk89 mentioned, the official docs of record for the mc admin commands are at
https://min.io/docs/minio/linux/reference/minio-mc-admin.html.

@dormanze
Copy link
Contributor Author

@harshavardhana Please approve my pr.

@harshavardhana harshavardhana changed the title doc:Update mc admin doc doc: Update mc admin doc Apr 17, 2023
@harshavardhana harshavardhana merged commit 4bc0aa7 into minio:master Apr 17, 2023
5 checks passed
@dormanze dormanze deleted the docUpdate branch April 20, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docs for changed mc commands
5 participants