Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent subcommand naming for list and remove with shortname #4548

Merged
merged 3 commits into from
Apr 17, 2023
Merged

Consistent subcommand naming for list and remove with shortname #4548

merged 3 commits into from
Apr 17, 2023

Conversation

dvaldivia
Copy link
Contributor

Description

Makes list and remove consistent across all sub-commands with the equivalent alias ls and rm respectively

Motivation and Context

Some commands had ls some had list some had both, same case for remove and ls

How to test this PR?

make and use as usual

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@dvaldivia
Consistent subcommand naming for list and remove with shortname
0f8e1fb 
Signed-off-by: Daniel Valdivia <hola@danielvaldivia.com>
@dvaldivia dvaldivia self-assigned this Apr 13, 2023
klauspost
klauspost approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

vadmeste
vadmeste approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana
Copy link
Member

@dvaldivia PTAL at build failures

@dvaldivia
Copy link
Contributor Author

ready @harshavardhana @poornas @vadmeste @klauspost @jinapurapu

@harshavardhana harshavardhana merged commit 6833118 into minio:master Apr 17, 2023
5 checks passed
@djwfyi djwfyi mentioned this pull request May 5, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadmeste vadmeste vadmeste approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

@poornas poornas poornas approved these changes

@klauspost klauspost klauspost approved these changes

@jinapurapu jinapurapu jinapurapu approved these changes

@donatello donatello Awaiting requested review from donatello

@kannappanr kannappanr Awaiting requested review from kannappanr

Assignees

@dvaldivia dvaldivia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dvaldivia @harshavardhana @vadmeste @poornas @klauspost @jinapurapu