Add name and description for service accounts #4569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donatello
force-pushed
the
enhance-service-account
branch
3 times, most recently
from
6d4d74e
to
33f424a
Compare
8 tasks
harshavardhana
approved these changes
May 15, 2023
harshavardhana
requested changes
May 15, 2023
- Adds "--name" and "--description" options to add/edit service account subcommands. - "--comment" option is now hidden, and if provided, will be read as description field if no description is given.
donatello
force-pushed
the
enhance-service-account
branch
from
33f424a
to
7b78544
Compare
harshavardhana
approved these changes
May 16, 2023
krisis
approved these changes
May 17, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds "--name" and "--description" options to add/edit service account subcommands.
Removes "--comment" option for a service account as the term may be confusing.
Motivation and Context
See minio/minio#17172
How to test this PR?
Try out the new options.
Types of changes
Checklist:
commit-idorPR #here)