Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix proxy not being used to test connectivity #4583

Merged
merged 1 commit into from May 28, 2023

Conversation

anjalshireesh
Copy link
Contributor

Description

The code to check SUBNET reachability was using default client without proxy, even when the proxy is set.

How to test this PR?

  • Register a cluster with subnet
  • Configure access to subnet only via proxy
  • Set the proxy using mc support proxy set {alias} {proxy-url}
  • Check that subnet related commands like mc support diag work fine in online mode (without --airgap)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@kannappanr kannappanr merged commit 298dbc5 into minio:master May 28, 2023
5 checks passed
@anjalshireesh anjalshireesh deleted the bugfixes branch May 29, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants