Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min, max and total request time to top api command #4702

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

aweisser
Copy link
Contributor

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the [Apache 2 license] (https://www.apache.org/licenses/LICENSE-2.0).
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

The min, max and total request time gives you a more complete picture of the API "perfomance"
in addition to the already existing avg request time.

grafik

Motivation and Context

The additional output helps to understand the latency of the incoming API calls even better.
In particular, how far the min and max RT differ from each other.

Other trace analysis tools like tshark also provide the min, max, avg and sum RT.
grafik

How to test this PR?

Execute mc support top api TARGET and watch the output.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@klauspost
Copy link
Contributor

Please take out "sum". It doesn't really provide any valuable information, that cannot already be deduced from calls and average.

@harshavardhana harshavardhana merged commit d47a2ba into minio:master Sep 29, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants