Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing colours on windows #4721

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Conversation

klauspost
Copy link
Contributor

@klauspost klauspost commented Oct 17, 2023

Description

#4705 removed all color from Windows output.

Motivation and Context

The world should have color diversity.

How to test this PR?

Run any command on Windows. Observe greyness.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

minio#4705 removed all color from Windows output.
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmd/main.go Show resolved Hide resolved
@harshavardhana harshavardhana merged commit d2a2bdb into minio:master Oct 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants