Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anonymize flag to support-diag #4742

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

anjalshireesh
Copy link
Contributor

@anjalshireesh anjalshireesh commented Nov 3, 2023

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the [Apache 2 license] (https://www.apache.org/licenses/LICENSE-2.0).
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

minio will now not anonymize hostnames by default. This is the "standard" mode of
anonymization. If user wants them to be anonymized, then they must pass --anonymize=strict

Motivation and Context

Retaining hostnames makes debugging easier.

How to test this PR?

  • Generate health report without passing --anonymize
  • Verify that hostnames are retained in the generated report
  • Verify same behavior by passing --anonymize=standard
  • Generate health report by passing --anonymize=strict
  • Verify that hostnames are anonymized in the generated report

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified.

@minio-trusted minio-trusted merged commit a5adf14 into minio:master Nov 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants