set-json to fail on custom policies without .json #4745
Conversation
The previous code only validates the file ext, so i think only
|
cmd/access-perms.go
Outdated
| @@ -28,12 +33,50 @@ func (b accessPerms) isValidAccessPERM() bool { | |||
| return false | |||
| } | |||
|
|
|||
| type PolicyDocument struct { | |||
There was a problem hiding this comment.
why a new struct - can you not use pkg/policy ?
the file extension check can be relaxed though. |
Do you mean I should remove it? |
Yes @r-scheele |
| @@ -52,7 +52,7 @@ var anonymousCmd = cli.Command{ | |||
|
|
|||
| USAGE: | |||
| {{.HelpName}} [FLAGS] set PERMISSION TARGET | |||
| {{.HelpName}} [FLAGS] set-json TARGET FILE | |||
| {{.HelpName}} [FLAGS] set-json FILE TARGET | |||
There was a problem hiding this comment.
Can you update the example below as well ?
Fix set-json command to fail on custom policies without .json
This commit addresses the bug where the
set-jsoncommand incorrectlysucceeds for custom policies even when the policy file doesn't have a .json
extension. The fix ensures that the command fails as expected, prompting the user to use the correct file.
./mc anonymous set-json myminio/mydata ~/test/anonymous.jsonNow,
set-jsonwill return an error message if the provided policy file is not a .json, aligning the behavior with the documented functionality.Related to the discussion with @kannappanr