Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add STS support for mc admin command #4754

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

pjuarezd
Copy link
Member

@pjuarezd pjuarezd commented Nov 11, 2023

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the [Apache 2 license] (https://www.apache.org/licenses/LICENSE-2.0).
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

add STS support for mc admin commands

Motivation and Context

To allow invoke subcommands in the admin section such as user, group, policy, etc.

Example:

MC_HOST_demomc=http://localhost:9000  \
MC_STS_ENDPOINT=https://sts.minio-operator.svc.cluster.local:4223/sts/ns-1 \
MC_WEB_IDENTITY_TOKEN_FILE=/var/run/secrets/kubernetes.io/serviceaccount/token \
./mc admin policy create demomc bucket-rw policy.json 

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@harshavardhana harshavardhana merged commit b1d4341 into minio:master Nov 12, 2023
5 checks passed
@ravindk89
Copy link
Contributor

@pjuarezd is this only for the Operator STS loop? Or could this also be used for non-Operator STS, e.g. OIDC or AD/LDAP loops?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants