Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tier: Add support of service principal auth for Azure #4787

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

vadmeste
Copy link
Member

@vadmeste vadmeste commented Dec 11, 2023

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the [Apache 2 license] (https://www.apache.org/licenses/LICENSE-2.0).
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Add new flags to mc ilm tier add command to support Azure storage
authentication using a service principal account:
--azure-sp-tenant-id
--azure-sp-client-id
--azure-sp-client-secret

Motivation and Context

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@vadmeste vadmeste marked this pull request as ready for review December 12, 2023 19:24
Add new flags to mc ilm tier add command to support Azure storage
authentication using a service principal account:
  --sp-tenant-id
  --sp-client-id
  --sp-client-secret
cmd/ilm-tier-add.go Outdated Show resolved Hide resolved
@harshavardhana harshavardhana merged commit 8da737f into minio:master Dec 14, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants