Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read new key license_v2 from SUBNET response #4788

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

anjalshireesh
Copy link
Contributor

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the [Apache 2 license] (https://www.apache.org/licenses/LICENSE-2.0).
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

SUBNET now has a v2 of license that is returned in the new key license_v2. mc will start reading and storing the same.
(The old key license is deprecated but is still available in SUBNET response to ensure that the current released version of mc doesn't break)

Motivation and Context

Stay up-to-date with license changes in SUBNET

How to test this PR?

Following commands should continue to work fine:

  • mc license register
  • mc license update
  • mc support diag
  • mc support perf
  • mc support profile
  • mc support inspect

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
SUBNET now has a v2 of license that is returned in the new key
`license_v2`. mc will start reading and storing the same.
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified.

@anjalshireesh anjalshireesh marked this pull request as ready for review December 14, 2023 04:46
@harshavardhana harshavardhana merged commit 28f44cb into minio:master Dec 14, 2023
5 checks passed
@anjalshireesh anjalshireesh deleted the license branch December 14, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants