Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add action for mc undo recursive #4822

Merged
merged 8 commits into from Jan 18, 2024
Merged

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Jan 15, 2024

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

mc undo --recursive minio/mytest/bin —force —action DELETE
Support the top version is DELETE will do that or do nothing.
mc undo --recursive minio/mytest/bin —force —action PUT
Support the top version is PUT will do that or do nothing.

Motivation and Context

How to test this PR?

Types of changes

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@jiuker jiuker linked an issue Jan 15, 2024 that may be closed by this pull request
@jiuker jiuker requested a review from shtripat January 15, 2024 10:26
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please explain the use case why we need this in PR description?

cmd/undo-main.go Outdated Show resolved Hide resolved
@jiuker
Copy link
Contributor Author

jiuker commented Jan 16, 2024

Can you please explain the use case why we need this in PR description?

The issue #4693 need this feature.

cmd/undo-main.go Outdated Show resolved Hide resolved
cmd/undo-main.go Outdated Show resolved Hide resolved
cmd/undo-main.go Outdated Show resolved Hide resolved
apply suggestion

apply suggestion

apply suggestion

apply suggestion

apply suggestion
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A cosmetic one.

cmd/undo-main.go Outdated Show resolved Hide resolved
Co-authored-by: Shubhendu <shubhendu.tripathi@gmail.com>
cmd/undo-main.go Show resolved Hide resolved
@jiuker jiuker requested a review from vadmeste January 18, 2024 02:32
cmd/undo-main.go Outdated Show resolved Hide resolved
cmd/undo-main.go Outdated Show resolved Hide resolved
cmd/undo-main.go Outdated Show resolved Hide resolved
cmd/undo-main.go Outdated Show resolved Hide resolved
jiuker and others added 2 commits January 18, 2024 14:15
Co-authored-by: Harshavardhana <harsha@minio.io>
@harshavardhana harshavardhana merged commit bb25267 into minio:master Jan 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mc undo recursive: option to select (PUT or DELETE)
5 participants