Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional tests: add a parameter for the full site cleaning test #4877

Merged
merged 5 commits into from Mar 30, 2024

Conversation

davlgd
Copy link
Contributor

@davlgd davlgd commented Mar 16, 2024

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Fix #4876

The latest mc rb test clean all the site data, and on the demo site, there are sometimes WORM objects put by some users and it leads to an failure. This test should only be run on sites on which the user knows he can clean everything without errors

Motivation and Context

I need to run functional tests without errors on the demo site, even if some user put WORM objects in it. The COMPLETE_RB_TEST allow to run the "clean everything" test when the user needs it. The parameter name can be changed if it doesn't comply to any mc development rule.

How to test this PR?

Launch make test with COMPLETE_RB_TEST parameter set to false/true

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

Fix minio#4876 

The latest `mc rb` test clean all the site data, and on the demo site, there are sometimes WORM files put by some users and it leads to an failure. This test should only be run on sites on which the user knows he can clean everything without errors
functional-tests.sh Outdated Show resolved Hide resolved
functional-tests.sh Outdated Show resolved Hide resolved
Co-authored-by: Harshavardhana <harsha@minio.io>
@bh4t
Copy link
Contributor

bh4t commented Mar 26, 2024

@harshavardhana PTAL when you get a chance.

@harshavardhana harshavardhana merged commit f740a6d into minio:master Mar 30, 2024
5 checks passed
@davlgd davlgd deleted the patch-1 branch March 31, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

functional tests not working because of a WORM protected file in play.min.io
4 participants